fix selective build validation and dtype build plumbing#19443
Open
arkadip-maitra wants to merge 1 commit intopytorch:mainfrom
Open
fix selective build validation and dtype build plumbing#19443arkadip-maitra wants to merge 1 commit intopytorch:mainfrom
arkadip-maitra wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19443
Note: Links to docs will display an error until the docs builds have been completed.
|
meta-cla
Bot
added
the
CLA Signed
Author
|
@pytorchbot label "release notes: build" |
pytorch-bot
Bot
added
the
release notes: build
Author
|
This is the first PR related to #11921, intentionally scoped to OSS CMake selective-build correctness and test coverage. If this direction looks good, I will follow up with separate PRs for the consolidated selector API and then docs/integration updates. |
arkadip-maitra
requested review from
JacobSzwejbka,
kirklandsign,
larryliu0820 and
lucylq
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pr related to #11921
this pr makes preset option checks handle string valued selector flags properly, fixes dtype selective generated target export/install plumbing, and adds coverage for the current
EXECUTORCH_SELECT_OPS_MODEL + EXECUTORCH_SELECT_OPS_LISTcomposition behavior.validated with commands:
python -m pytest tools/cmake/common/preset_test.py -q --override-ini flake-finder=false --override-ini flake-runs=1PYTHON_EXECUTABLE=python bash .ci/scripts/test_model.sh add cmake portablePYTHON_EXECUTABLE=python bash examples/selective_build/test_selective_build.sh cmake